Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs[patch]: properly load/use env vars #4711

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Conversation

bracesproul
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 10:16pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 11, 2024 10:16pm

@bracesproul bracesproul marked this pull request as ready for review March 11, 2024 22:04
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels Mar 11, 2024
@@ -5,6 +5,7 @@
// eslint-disable-next-line import/no-extraneous-dependencies
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've reviewed the PR and noticed that the addition of require("dotenv").config(); is flagging the change for maintainers to review, as it explicitly accesses and reads environment variables via the process.env object. Great work, and let me know if you need any further assistance!

@bracesproul bracesproul merged commit 67e510f into main Mar 11, 2024
14 checks passed
@bracesproul bracesproul deleted the brace/fix-loading-env-vars branch March 11, 2024 22:21
Janaka-Steph pushed a commit to Janaka-Steph/langchainjs that referenced this pull request Mar 15, 2024
* docs[patch]: properly load/use env vars

* cr
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant