Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple[patch]: Switch deprecated model.call to model.invoke in tests and examples #4726

Merged
merged 5 commits into from
Mar 13, 2024

Conversation

janvi-kalra
Copy link
Contributor

@janvi-kalra janvi-kalra commented Mar 12, 2024

No-op.
Noticed that model.call was deprecated so updating the library and documentation to mode.invoke
Starter PR just to get the lay of the land
Ran yarn test and all tests continued to pass.

Copy link

vercel bot commented Mar 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2024 11:47pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 12, 2024 11:47pm

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. auto:refactor A large refactor of a feature(s) or restructuring of many files labels Mar 12, 2024
@@ -43,6 +43,8 @@ docs/use_cases/question_answering/sources.md
docs/use_cases/question_answering/sources.mdx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to have happened automatically - didn't manually change this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, all good there

@jacoblee93
Copy link
Collaborator

Fantastic, thank you!

@jacoblee93 jacoblee93 changed the title Update Decreprecated model.call to model.invoke all[patch]: Switch deprecated model.call to model.invoke in tests and examples Mar 12, 2024
@jacoblee93 jacoblee93 changed the title all[patch]: Switch deprecated model.call to model.invoke in tests and examples multiple[patch]: Switch deprecated model.call to model.invoke in tests and examples Mar 12, 2024
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Mar 13, 2024
@jacoblee93 jacoblee93 merged commit 8d45575 into langchain-ai:main Mar 13, 2024
20 checks passed
@jacoblee93
Copy link
Collaborator

Thank you! And congrats on your first PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:refactor A large refactor of a feature(s) or restructuring of many files lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants