community[minor]: Implement addGraphDocuments method for neo4j graph #4761
Conversation
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:improvement
easwee
changed the title
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -1,19 +1,37 @@ | |||
| /* eslint-disable no-process-env */ | |||
There was a problem hiding this comment.
Hey there! 👋 This is a friendly flag to highlight that the recent change in the PR adds, accesses, and requires environment variables via process.env. It's important for maintainers to review this change to ensure proper handling of environment variables. Keep up the great work! 🚀
jacoblee93
changed the title
| @@ -1,4 +1,6 @@ | |||
| import neo4j, { RoutingControl } from "neo4j-driver"; | |||
| import { createHash } from "crypto"; | |||
There was a problem hiding this comment.
I am not sure if this is intended to work in web environments (e.g. Next.js) but I would suggest using this:
There was a problem hiding this comment.
Updated to use insecureHash
| } | ||
| } | ||
|
|
||
| export class GraphDocument extends Serializable { |
There was a problem hiding this comment.
Could this extend Document instead? It will be a bit more interchangeable with other RAG pipeline things in the framework if we do it that way.
There was a problem hiding this comment.
Updated - please review
|
LGTM |
|
|
||
| relationships: Relationship[]; | ||
|
|
||
| source: Document; |
There was a problem hiding this comment.
Unnest this since we're now extending Document directly? Otherwise there's no point
There was a problem hiding this comment.
Basically implement pageContent and metadata
There was a problem hiding this comment.
Would consisteny between python and JS be a higher priority? IMO, there is not much value in extending the doc for rag, as we never use the graph doc in retrieval setting, it's only used for ingestion atm. Even if we wanted to use it in retrieval, it would need custom components since none use nodes or rels atm
|
Really sorry for the delay - see above. |
|
Thank you for your patience! |
jacoblee93
added
lgtm
Porting over add_graph_documents method from python.