anthropic[minor]: fix nested object fixArrayXMLParameters #4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When parsing a nested object in fixArrayXMLParameters, the base schema is passed on the recursive call. This causes a mismatch between the xml object (the nested type) and the schema (still the base type) I'm not very happy with type assertion for the schema, not sure what's the correct check to make here though.
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:bug
|
@davidfant I think you had this in your PR initially too? |
|
Thank you! Seems to work for me! |
jacoblee93
reviewed
Mar 15, 2024
| @@ -100,7 +100,10 @@ export function fixArrayXMLParameters( | |||
| typeof xmlParameters[key] === "object" && | |||
| xmlParameters[key] !== null | |||
| ) { | |||
| fixedParameters[key] = fixArrayXMLParameters(schema, xmlParameters[key]); | |||
| fixedParameters[key] = fixArrayXMLParameters( | |||
| schema.properties[key] as JsonSchema7ObjectType, | |||
There was a problem hiding this comment.
@davidfant had:
{
...schema.properties[key],
definitions: schema.definitions,
}
for the first arg - does that make sense here?
There was a problem hiding this comment.
This will break JSON schema definitions. TBH I'm not sure how well this XML situation would even work with JSON schema definitions though, so it might not practically matter, but I'd still prefer adding in definitions
There was a problem hiding this comment.
Will change it to yours
jacoblee93
added
question
…fix-antropic-tools
dosubot
bot
added
size:S
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When parsing a nested object in fixArrayXMLParameters, the base schema is passed on the recursive call. This causes a mismatch between the xml object (the nested type) and the schema (still the base type)
I'm not very happy with type assertion for the schema, not sure what's the correct check to make here though.