openai[patch]: Bugfix: try catch around JSON stringify/parse when counting OpenAI function calling tokens #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…function call arguments tokens
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:M
davidfant
force-pushed
the
bugfix/try-catch-arg-token-counting
branch
from
f4a5cb9
to
834d326
Compare
dosubot
bot
added
size:S
davidfant
commented
Mar 16, 2024
| ); | ||
| ); | ||
| } catch (error) { | ||
| console.error("Error parsing function arguments", error, JSON.stringify(openAIMessage.additional_kwargs.function_call)); |
There was a problem hiding this comment.
Your call how you want to approach this kind of logging. I've had this as a patch-package patch for a while. Logging this is useful bc then I can easily see when arguments is invalid JSON
There was a problem hiding this comment.
Yes, this seems reasonable, thank you!
jacoblee93
changed the title
…bugfix/try-catch-arg-token-counting
|
Thank you for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If OpenAI doesn't return valid JSON in arguments (which is rare, but happens) the OpenAI invocation just throws because token counting fails. Counting the tokens without removing newlines/spaces (which I assume is needed bc it was already there, but I don't know for sure), should be a good enough approximation of token count