Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redis[patch]: Escape additional metadata characters for RedisSearch metadata filtering usage #4814

Merged
merged 5 commits into from
Mar 20, 2024

Conversation

leejona16
Copy link
Contributor

The : and " characters found in the stringified JSON are special characters in redisSearch queries, so we need to escape them in the stringified metadata if we want to be able to search the entire JSON object.

This enables key/value sub-string searches of the stringified metadata object for filtering purposes.

Copy link

vercel bot commented Mar 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 20, 2024 4:37pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 20, 2024 4:37pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Mar 18, 2024
@jacoblee93 jacoblee93 changed the title Escape additional metadata characters for RedisSearch metadata filtering usage redis[patch]: Escape additional metadata characters for RedisSearch metadata filtering usage Mar 19, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Mar 19, 2024
@jacoblee93
Copy link
Collaborator

Could you fix the failing test?

@leejona16
Copy link
Contributor Author

Sorry about that- updated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants