Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pinecone[minor]: Bump dep to 2.2 and add sourceTag #4925

Merged
merged 2 commits into from
Mar 29, 2024

Conversation

bracesproul
Copy link
Collaborator

No description provided.

@bracesproul bracesproul marked this pull request as ready for review March 29, 2024 18:05
Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 7:33pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Mar 29, 2024 7:33pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Mar 29, 2024
@@ -39,7 +39,7 @@
"license": "MIT",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I noticed that the dependency for "@pinecone-database/pinecone" has been updated from "^2.0.0" to "^2.2.0", indicating a minor-level change. I've flagged this for your review to ensure it aligns with the project's dependency management strategy. Keep up the great work! 🚀

@@ -210,4 +210,40 @@ describe.skip("PineconeStore", () => {
expect(results.length).toEqual(1);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just a heads up that I've flagged a change in the PR for review. The added code references an environment variable using process.env, so it's important to ensure that the handling of environment variables is in line with best practices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant