core[minor]: Add runId to RunnableConfig #4954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:L
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
langchain-core/src/runnables/base.ts
Outdated
| @@ -1520,17 +1539,19 @@ export class RunnableSequence< | |||
There was a problem hiding this comment.
Hey team, just a heads up that this PR introduces a new asynchronous HTTP request using the handleChainStart method. This comment is to flag the change for maintainers to review the addition of this new request. Let me know if you have any questions or need further clarification!
jacoblee93
reviewed
Apr 3, 2024
| undefined, | ||
| extra, | ||
| undefined, | ||
| undefined, | ||
| handledOptions.runName | ||
| ); | ||
|
|
||
| // eslint-disable-next-line no-param-reassign | ||
| delete handledOptions.runId; |
There was a problem hiding this comment.
there is no above?
jacoblee93
reviewed
Apr 3, 2024
jacoblee93
reviewed
Apr 3, 2024
|
See comments - also, why not implement for LLMs too? |
…to brace/add-run-id-runnable-config
|
@jacoblee93 added to LLMs, added some tests and cleaned up a couple other places. Should be good to go now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not implemented for LLMs yet. Py is very different from JS with base implementation, so it's not as simple as translate syntax