Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langchain[patch]: SelfQueryRetriever - fallback to similarity search #4960

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

guidev
Copy link
Contributor

@guidev guidev commented Apr 2, 2024

If there are no metadata filters (NO_FILTER), instead of explicitly returning [], it should fallback to a similarity search

This also matches the python implementation

If there are no metadata filters (NO_FILTER), instead of explicitly returning [], it should fallback to a similarity search
Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 2, 2024 5:00pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 2, 2024 5:00pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Apr 2, 2024
@jacoblee93 jacoblee93 changed the title SelfQueryRetriever - fallback to similarity search langchain[patch]: SelfQueryRetriever - fallback to similarity search Apr 3, 2024
@jacoblee93
Copy link
Collaborator

Thank you! Sorry for the delay

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Apr 5, 2024
@jacoblee93 jacoblee93 merged commit 82de094 into langchain-ai:main Apr 6, 2024
17 checks passed
@renovate renovate bot mentioned this pull request May 9, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants