Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[patch]: Fix strict mode comparison and formatting for llm graph transformer #4988

Merged
merged 5 commits into from
Apr 9, 2024
Merged

community[patch]: Fix strict mode comparison and formatting for llm graph transformer #4988

merged 5 commits into from
Apr 9, 2024

Conversation

tomasonjo
Copy link
Contributor

@tomasonjo tomasonjo commented Apr 5, 2024 •
edited

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 5, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 5, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2024 5:02am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 6, 2024 5:02am

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Apr 5, 2024
@tomasonjo
Copy link
Contributor Author

Also removed serialization of the document for graph document

@easwee
Copy link
Contributor

easwee commented Apr 5, 2024

Looks ok.

@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93
Copy link
Collaborator

jacoblee93 commented Apr 6, 2024 •
edited

Could you please run yarn format?

@jacoblee93 jacoblee93 changed the title Fix strict mode comparison and formatting for llm graph transformer community[patch]: Fix strict mode comparison and formatting for llm graph transformer Apr 6, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 6, 2024
@tomasonjo
Copy link
Contributor Author

Done

@jacoblee93 jacoblee93 merged commit a2e436e into langchain-ai:main Apr 9, 2024
23 checks passed
@jacoblee93
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tomasonjo @easwee @jacoblee93