Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all[patch]: Deprecate and update instances of deprecated code #5013

Merged
merged 12 commits into from
Apr 26, 2024

Conversation

bracesproul
Copy link
Collaborator

@bracesproul bracesproul commented Apr 8, 2024

Search keywords:
examples[patch]
core[minor] - deprecate methods
langchain[patch]
community[patch]
google-common[patch]

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 6:34pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 9, 2024 6:34pm

@jacoblee93
Copy link
Collaborator

I think we tried to do this a while back and decided it wasn't worth fixing all the instances in tests, but wouldn't hurt I suppose. If build is failing feel free to revert those.

@bracesproul bracesproul marked this pull request as ready for review April 9, 2024 19:43
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels Apr 9, 2024
@bracesproul bracesproul merged commit 022bb49 into main Apr 26, 2024
23 checks passed
@bracesproul bracesproul deleted the brace/deprecate-and-remove branch April 26, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants