Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[minor]: feat: QdrantTranslator for self-query retrieval #5163

Merged
merged 11 commits into from
Apr 26, 2024
Merged

community[minor]: feat: QdrantTranslator for self-query retrieval #5163

merged 11 commits into from
Apr 26, 2024

Conversation

Anush008
Copy link
Contributor

@Anush008 Anush008 commented Apr 20, 2024 •
edited

Description

This PR adds a new QdrantTranslator class for using SelfQueryRetriever with the Qdrant vector store.

P.S. It's 400 lines of test code, 200 lines of doc. The implementation is about 200 lines. Please do take a look.

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Apr 20, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 20, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 11:25pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 26, 2024 11:25pm

@dosubot dosubot bot added the auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features label Apr 20, 2024
dosubot[bot]
dosubot bot reviewed Apr 20, 2024
View reviewed changes
langchain/package.json Outdated
@@ -1232,6 +1236,7 @@
"@langchain/scripts": "~0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that this PR adds a new regular dependency, "@qdrant/js-client-rest", to the project. I've flagged this for your review to ensure it aligns with our dependency management strategy. Keep up the great work!

dosubot[bot]
dosubot bot reviewed Apr 20, 2024
View reviewed changes
langchain/src/retrievers/self_query/tests/qdrant_self_query.int.test.ts Outdated
@@ -0,0 +1,406 @@
import { test } from "@jest/globals";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey team, just a heads up that I've flagged a new external HTTP request being made using the QdrantClient in this PR. It's important for maintainers to review this change to ensure it aligns with the project's requirements and best practices.

@jacoblee93 jacoblee93 changed the title feat: QdrantTranslator for self-query retrieval langchain[minor]: feat: QdrantTranslator for self-query retrieval Apr 22, 2024
@jacoblee93
Copy link
Collaborator

Seems fine overall - could you add some docs?

@jacoblee93 jacoblee93 added the close PRs that need one or two touch-ups to be ready label Apr 22, 2024
@Anush008 Anush008 mentioned this pull request Apr 25, 2024
Closed
@Anush008
Merge pull request #1 from Anush008/self-query-qdrant-doc
4aba615 
docs: Qdrant self-query retriever
@Anush008
Copy link
Contributor Author

Pushed the docs to this PR as suggested.

@jacoblee93 jacoblee93 added lgtm PRs that are ready to be merged as-is and removed close PRs that need one or two touch-ups to be ready labels Apr 26, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Apr 26, 2024
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Apr 26, 2024
@jacoblee93
Copy link
Collaborator

Thank you! We are moving all of these translators to @langchain/community in 0.2, so just going to put it here to get a head start on it.

@jacoblee93 jacoblee93 changed the title langchain[minor]: feat: QdrantTranslator for self-query retrieval community[minor]: feat: QdrantTranslator for self-query retrieval Apr 26, 2024
@jacoblee93 jacoblee93 merged commit 916114b into langchain-ai:main Apr 26, 2024
16 checks passed
@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosubot dosubot[bot] dosubot left review comments

Assignees
No one assigned
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features lgtm PRs that are ready to be merged as-is size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Anush008 @jacoblee93