Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

community[patch]: fix: Zhipu api key expired after 3 minutes #5182

Merged
merged 3 commits into from
Apr 26, 2024
Merged

community[patch]: fix: Zhipu api key expired after 3 minutes #5182

merged 3 commits into from
Apr 26, 2024

Conversation

jeasonnow
Copy link
Contributor

Fixes #5037

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Apr 23, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 25, 2024 7:44am
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 25, 2024 7:44am

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Apr 23, 2024
@jacoblee93
Copy link
Collaborator

Thanks! Could you make sure you run yarn format?

@jacoblee93
Copy link
Collaborator

Getting:

@langchain/community:build: src/embeddings/zhipuai.ts(62,5): error TS2322: Type 'string | undefined' is not assignable to type 'string'.

Can you have a look?

@jeasonnow
Copy link
Contributor Author

Getting:

@langchain/community:build: src/embeddings/zhipuai.ts(62,5): error TS2322: Type 'string | undefined' is not assignable to type 'string'.

Can you have a look?

Okay, I’ll fix it right away.

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Apr 25, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Apr 25, 2024
@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label Apr 26, 2024
@jacoblee93 jacoblee93 changed the title fix: Zhipu api key expired after 3 minutes community[patch]: fix: Zhipu api key expired after 3 minutes Apr 26, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 merged commit 5c51f0e into langchain-ai:main Apr 26, 2024
17 checks passed
@jeasonnow jeasonnow deleted the fix/zhipu_api_key branch April 27, 2024 03:30
@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dosubot dosubot[bot] dosubot left review comments

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZhipuAIEmbeddings bug
2 participants
@jeasonnow @jacoblee93