core[patch]: Bugfix: cache missed because callback _parentRunId
passed in to cache key function (_getSerializedCacheKeyParametersForCall
)
#5205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a patch I've applied locally to fix the problem below. Whoever understands this code should prob change this fix to be more appropriate. Also, the TS types don't reflect a "config" being in callOptions, so idk where that comes from.
Problem
Here's an example output from
_getSerializedCacheKeyParametersForCall
, which is used to generate BaseLanguageModel cache keys:What's problematic about this is
"_parentRunId":"1f2f3a62-f04c-4e82-9bd0-11c8747c734b"
, which causes the cache key to be different for each run. My fix makes sure thatconfig
isn't being passed in when generating this key.