google-common[patch]: remove all additionalProperties for gemini #5247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:bug
bracesproul
changed the title
bracesproul
reviewed
Apr 29, 2024
libs/langchain-google-common/src/utils/zod_to_gemini_parameters.ts
Outdated
Show resolved
Hide resolved
|
Oh wow, I didn't expect someone to tackle this so quickly. I mostly opened the issue to remind myself to get to it eventually. Thank you, @jeasonnow. |
jeasonnow
force-pushed
the
fix/5240
branch
2 times, most recently
from
8cda51e
to
5b23814
Compare
libs/langchain-google-common/src/utils/zod_to_gemini_parameters.ts
Outdated
Show resolved
Hide resolved
bracesproul
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5240