Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Browserbase loader #5248

Merged
merged 6 commits into from
May 1, 2024
Merged

Conversation

mishushakov
Copy link
Contributor

We're adding Browserbase SDK integration to the JS-version of LangChain. This would allow loading webpages in a headless browser.

Copy link

vercel bot commented Apr 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 0:06am
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 1, 2024 0:06am

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features labels Apr 29, 2024
@@ -1222,6 +1226,7 @@
"@aws-sdk/credential-provider-node": "^3.388.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that the addition of "@browserbasehq/sdk" in the package.json file introduces a new dependency to the project. This change is flagged for maintainers to review the impact on peer/dev/hard dependencies. Keep up the great work!

Copy link
Collaborator

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good start! I left some comments, mainly nits.

Let me know when they've been implemented, and re-request my review. It'll be great to get this merged!

langchain/src/document_loaders/web/browserbase.ts Outdated Show resolved Hide resolved
langchain/src/document_loaders/web/browserbase.ts Outdated Show resolved Hide resolved
langchain/src/document_loaders/web/browserbase.ts Outdated Show resolved Hide resolved
langchain/src/document_loaders/web/browserbase.ts Outdated Show resolved Hide resolved
@mishushakov
Copy link
Contributor Author

Thank you very much!! 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:enhancement A large net-new component, integration, or chain. Use sparingly. The largest features in progress PRs that are in progress but not ready to merge size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants