Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

azure-openai[patch]: fix only first embedding generated when batching enabled #5251

Merged
merged 4 commits into from
Apr 29, 2024
Merged

azure-openai[patch]: fix only first embedding generated when batching enabled #5251

merged 4 commits into from
Apr 29, 2024

Conversation

sinedied
Copy link
Contributor

When batching is enabled, only the first embedding for the batch was generated. This PR fixes that.

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 29, 2024
@vercel Vercel
Copy link

vercel bot commented Apr 29, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 11:38pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview Apr 29, 2024 11:38pm

@dosubot dosubot bot added the auto:bug Related to a bug, vulnerability, unexpected error with an existing feature label Apr 29, 2024
bracesproul
bracesproul approved these changes Apr 29, 2024
View reviewed changes
Copy link
Collaborator

@bracesproul bracesproul left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I committed the suggestions I made fyi.

Will get this released soon!

Edit: Pushed up a commit running yarn format

libs/langchain-azure-openai/src/embeddings.ts Outdated Show resolved Hide resolved
libs/langchain-azure-openai/src/embeddings.ts Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label Apr 29, 2024
@bracesproul bracesproul merged commit 4c8e190 into langchain-ai:main Apr 29, 2024
17 checks passed
@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees
No one assigned
Labels
auto:bug Related to a bug, vulnerability, unexpected error with an existing feature lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sinedied @bracesproul