Skip to content

fix handling of multibyte characters in streams for google-gauth #5286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bracesproul merged 2 commits into from
May 6, 2024
Merged

fix handling of multibyte characters in streams for google-gauth #5286

bracesproul merged 2 commits into from
May 6, 2024

Conversation

@pokutuna
Copy link
Contributor

@pokutuna pokutuna commented May 4, 2024

Fixes #5285

  • There were only integration tests in google-gauth, but I have added some unit tests. Is this okay?
  • I also used npm link to verify locally that the issue has been resolved.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 4, 2024
@vercel
Copy link

vercel bot commented May 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 5:37pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview May 6, 2024 5:37pm

@dosubot dosubot bot added the auto:bug label May 4, 2024
pokutuna
pokutuna commented May 4, 2024
View reviewed changes
libs/langchain-google-gauth/src/auth.ts
import { GoogleAuth, GoogleAuthOptions } from "google-auth-library";

class NodeJsonStream extends JsonStream {
export class NodeJsonStream extends JsonStream {
Copy link
Contributor Author

@pokutuna pokutuna May 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I exported this because it seemed complex to test while mocking GAuthClient.

@vercel vercel bot temporarily deployed to Preview – langchainjs-docs May 4, 2024 20:53 Inactive
@vercel vercel bot temporarily deployed to Preview – langchainjs-api-refs May 4, 2024 20:53 Inactive
@pokutuna pokutuna mentioned this pull request May 5, 2024
Closed
5 tasks
bracesproul
bracesproul reviewed May 6, 2024
View reviewed changes
Copy link
Member

@bracesproul bracesproul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, cc @afirstenberg for another look

@afirstenberg
Copy link
Contributor

afirstenberg commented May 6, 2024

LGTM
Thanks for catching and fixing this!

@dosubot dosubot bot added the lgtm PRs that are ready to be merged as-is label May 6, 2024
@vercel vercel bot temporarily deployed to Preview – langchainjs-docs May 6, 2024 17:37 Inactive
@vercel vercel bot temporarily deployed to Preview – langchainjs-api-refs May 6, 2024 17:37 Inactive
@bracesproul bracesproul merged commit 235f447 into langchain-ai:main May 6, 2024
@pokutuna
Copy link
Contributor Author

pokutuna commented May 7, 2024

Thank you for reviewing & quick release!

@aechegoyan17 aechegoyan17 mentioned this pull request Jun 6, 2024
Open
@riderx riderx mentioned this pull request Jun 9, 2024
Closed
This was referenced Jun 11, 2024
Merged
Merged
@dosubot dosubot bot mentioned this pull request Aug 12, 2024
Closed
5 tasks
@pokutuna pokutuna mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bracesproul bracesproul bracesproul approved these changes

Assignees

No one assigned

Labels

lgtm PRs that are ready to be merged as-is size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replacement Character(�) appears in multibyte text output from Google VertexAI

3 participants

@pokutuna @afirstenberg @bracesproul