fix handling of multibyte characters in streams for google-gauth #5286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:bug
pokutuna
commented
May 4, 2024
| @@ -8,12 +8,19 @@ import { | |||
| } from "@langchain/google-common"; | |||
| import { GoogleAuth, GoogleAuthOptions } from "google-auth-library"; | |||
|
|
|||
| class NodeJsonStream extends JsonStream { | |||
| export class NodeJsonStream extends JsonStream { | |||
There was a problem hiding this comment.
I exported this because it seemed complex to test while mocking GAuthClient.
5 tasks
bracesproul
reviewed
May 6, 2024
|
LGTM |
bracesproul
approved these changes
May 6, 2024
|
Thank you for reviewing & quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5285