Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[minor]: RunnableLambda should consume (async) iterator if the wrapped function returns one #5342

Merged
merged 8 commits into from
May 13, 2024

Conversation

nfcampos
Copy link
Collaborator

Fixes # (issue)

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 5:03pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 5:03pm

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:improvement Medium size change to existing code to handle new use-cases labels May 13, 2024
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 13, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 13, 2024
@nfcampos nfcampos changed the title core: RunnableLambda should consume async iterator if the wrapped function returns one core: RunnableLambda should consume (async) iterator if the wrapped function returns one May 13, 2024
@jacoblee93 jacoblee93 changed the title core: RunnableLambda should consume (async) iterator if the wrapped function returns one core[minor]: RunnableLambda should consume (async) iterator if the wrapped function returns one May 13, 2024
@jacoblee93
Copy link
Collaborator

Thank you!

@jacoblee93 jacoblee93 merged commit 5bfe24c into main May 13, 2024
23 checks passed
@jacoblee93 jacoblee93 deleted the nc/13may/runnable-lambda-iterator branch May 13, 2024 17:28
bracesproul added a commit that referenced this pull request May 13, 2024
* core[minor]: RunnableLambda should consume (async) iterator if the wrapped function returns one (#5342)

* core: RunnableLambda should consume async iterator if the wrapped function returns one

* Consume iterators too

* Add tests

* Dont interpret arrays/sets/etc as iterators

* Implement in invoke too

* Fix async storage propagation

* Handle any async iterable

* Add more tests

* community[minor]: Improve Azure Cosmos DB vector store support (#5197)

* feat: add delete by filter

* feat: return added document ids

* fix: delete by id

* test: update integration tests

* feat: add automatic index creation

* Update azure_cosmosdb.ts

* refactor: separate ids and filter params for delete()

* refactor: use a single param for delete

* test: fix unit tests

* Address feedback

---------

Co-authored-by: Jacob Lee <jacoblee93@gmail.com>

* Revert "Merge branch 'v0.1' into main" (#5345)

This reverts commit db5ab3f, reversing
changes made to 2b3b194.

---------

Co-authored-by: Nuno Campos <nuno@boringbits.io>
Co-authored-by: Yohan Lasorsa <noda@free.fr>
Co-authored-by: Jacob Lee <jacoblee93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:improvement Medium size change to existing code to handle new use-cases lgtm PRs that are ready to be merged as-is size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants