Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore[deps]: update js-tiktoken to 1.0.12 to support o200k_base #5354

Merged
merged 1 commit into from
May 14, 2024

Conversation

dqbd
Copy link
Collaborator

@dqbd dqbd commented May 14, 2024

Fixes # (issue)

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:45am
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 0:45am

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs labels May 14, 2024
@@ -43,7 +43,7 @@
"ansi-styles": "^5.0.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed that the "js-tiktoken" dependency has been updated from "^1.0.8" to "^1.0.12", which affects the hard dependency of the project. I've flagged this for your review as it's an important change to the project's dependencies. Keep up the great work!

@@ -41,7 +41,7 @@
"@azure/core-auth": "^1.5.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I noticed the change in the "js-tiktoken" dependency version from "^1.0.7" to "^1.0.12" in the package.json file. This comment is to flag the dependency change for maintainers to review and ensure it aligns with the project's peer/dev/hard dependencies. Great work on the PR!

@@ -39,7 +39,7 @@
"license": "MIT",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! 👋 I noticed the update to the "js-tiktoken" dependency in the package.json file, which seems to be a hard dependency change. I've flagged this for your review as it may impact the project's functionality. Keep up the great work! 🚀

@jacoblee93
Copy link
Collaborator

Thank you so much!

@jacoblee93 jacoblee93 added the lgtm PRs that are ready to be merged as-is label May 14, 2024
@jacoblee93 jacoblee93 merged commit 06c4a3e into main May 14, 2024
23 checks passed
@jacoblee93 jacoblee93 deleted the dqbd/js-tiktoken-o200k_base branch May 14, 2024 00:46
@jeasonnow jeasonnow mentioned this pull request May 14, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:nit Small modifications/deletions, fixes, deps or improvements to existing code or docs lgtm PRs that are ready to be merged as-is size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants