Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core[major]: Update streamEvent signature to return IterableReadableStream #5360

Merged
merged 3 commits into from
May 15, 2024

Conversation

jacoblee93
Copy link
Collaborator

@jacoblee93 jacoblee93 commented May 14, 2024

Technically breaking although in practice it should behave mostly the same, so will not backport this to 0.1.

Will allow us to pass streamEvents streams in places that require a ReadableStream (HTTP Response is the major one)

@bracesproul @nfcampos

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langchainjs-api-refs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 6:19pm
langchainjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 6:19pm

@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder labels May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto:documentation Changes to documentation and examples, like .md, .rst, .ipynb files. Changes to the docs/ folder size:XXL This PR changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant