-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openai[patch]: Update default headers azure & Add Token Provider Check #5379
Merged
jacoblee93
merged 8 commits into
langchain-ai:main
from
sarangan12:update_default_headers_Azure
May 15, 2024
Merged
openai[patch]: Update default headers azure & Add Token Provider Check #5379
jacoblee93
merged 8 commits into
langchain-ai:main
from
sarangan12:update_default_headers_Azure
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
auto:improvement
Medium size change to existing code to handle new use-cases
labels
May 15, 2024
dosubot
bot
added
size:M
This PR changes 30-99 lines, ignoring generated files.
and removed
size:S
This PR changes 10-29 lines, ignoring generated files.
labels
May 15, 2024
sarangan12
changed the title
Update default headers azure
Update default headers azure & Add Token Provider Check
May 15, 2024
sinedied
reviewed
May 15, 2024
sinedied
reviewed
May 15, 2024
sinedied
reviewed
May 15, 2024
@jacoblee93 could you help us get this one merged? 🙏 It fixes a blocking issue when the token provider, and sets the user agent in a similar way as we did in the previous Azure Open integration. Thank you! |
Co-authored-by: Yohan Lasorsa <noda@free.fr>
Co-authored-by: Yohan Lasorsa <noda@free.fr>
Co-authored-by: Yohan Lasorsa <noda@free.fr>
Sure, can cherry pick this one too if urgent. |
dosubot
bot
added
size:S
This PR changes 10-29 lines, ignoring generated files.
and removed
size:M
This PR changes 30-99 lines, ignoring generated files.
labels
May 15, 2024
jacoblee93
changed the title
Update default headers azure & Add Token Provider Check
openai[patch]: Update default headers azure & Add Token Provider Check
May 15, 2024
jacoblee93
pushed a commit
that referenced
this pull request
May 15, 2024
* Update Default Headers for Azure OpenAI Requests * nit * Update user agent string * Add Token Provider check * Update libs/langchain-openai/src/azure/llms.ts Co-authored-by: Yohan Lasorsa <noda@free.fr> * Update libs/langchain-openai/src/azure/embeddings.ts Co-authored-by: Yohan Lasorsa <noda@free.fr> * Update libs/langchain-openai/src/azure/chat_models.ts Co-authored-by: Yohan Lasorsa <noda@free.fr> * Format the code --------- Co-authored-by: Yohan Lasorsa <noda@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto:improvement
Medium size change to existing code to handle new use-cases
lgtm
PRs that are ready to be merged as-is
size:S
This PR changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to:
@langchain/openai
library.@achandmsft @deyaaeldeen @xirzec FYI.....