changed TextSplitter class to align with langchain #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zacharypfiz
changed the title
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been playing around with langchain and langchainjs and noticed that the textsplitters were producing different results. My goal is to align the textsplitters in langchainjs to be more similar to the langchain textsplitters.
I changed one line of conditional logic that was different between the two libraries. In the mergeSplits function:
langchain: if (total + _len + (separator_len if len(current_doc) > 0 else 0) > self._chunk_size):
langchainjs: if (total + _len >= this.chunkSize)
new langchainjs: if (total + _len + (currentDoc.length > 0 ? separator.length : 0) > this.chunkSize)