Use workspace TS version in VSCode #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, VSCode uses its built-in TypeScript version, which is currently 5.x, however langchainjs is using 4.x for its build, so it's possible for contributors to see errors in their editor that don't match the output from the build, or vice-versa.
This default behavior surprised me; it bit me a few times while working on an experiment to improve type-coverage for prompts, as there were changes to how types are inferred in TS 5.
This PR modifies the VSCode workspace settings to use the version from the workspace (4.x), rather than VSCode's built-in version, which should hopefully save contributors the same frustrations.
To do this I just used the
Select TypeScript versioncommand from VSCode, like so:Screen.Recording.2023-04-15.at.10.59.44.AM.mov