Add FewShotExamples managed value (redo)
#444
Conversation
langgraph/checkpoint/memory.py
Outdated
| loop = asyncio.get_running_loop() | ||
| iter = await loop.run_in_executor(None, self.search, metadata_query) | ||
|
|
||
| def next_item(iter: Iterator[CheckpointTuple]) -> CheckpointTuple: |
There was a problem hiding this comment.
I originally tried to copy the implementation from alist(), but it was not working as expected since StopIteration is raised in the subprocess, not the main thread.
I'm not sure if alist() actually works as expected.
There was a problem hiding this comment.
signature seems wrong? also this function seems equivalent to next(iter, None)
There was a problem hiding this comment.
I'll adopt the implementation from this PR: #447
langgraph/checkpoint/sqlite.py
Outdated
| with self.cursor(transaction=False) as cur: | ||
| cur.execute( | ||
| query, | ||
| (() if before is None else (before["configurable"]["thread_ts"],)), |
There was a problem hiding this comment.
I want to format this nicer.
langgraph/checkpoint/sqlite.py
Outdated
|
|
||
| where = "WHERE " | ||
| for query_key, query_value in metadata_query.items(): | ||
| where += f"json_extract(CAST(metadata AS TEXT), '$.{query_key}') {_where_value(query_value)} AND " |
There was a problem hiding this comment.
Not necessarily performant to call json_extract() for each metadata query key, but it's the simplest way to do it without creating a subtable, etc.
langgraph/checkpoint/sqlite.py
Outdated
| query = ( | ||
| f"SELECT thread_id, thread_ts, parent_ts, checkpoint, metadata FROM checkpoints {search_where(metadata_query)}ORDER BY thread_ts DESC" | ||
| if before is None | ||
| else f"SELECT thread_id, thread_ts, parent_ts, checkpoint, metadata FROM checkpoints {search_where(metadata_query)}AND thread_ts < ? ORDER BY thread_ts DESC" |
There was a problem hiding this comment.
This is a bug (search_where() can return empty string). Need to fix.
…_item() iterator function.
langgraph/checkpoint/sqlite.py
Outdated
| @@ -382,3 +437,46 @@ def put( | |||
| "thread_ts": checkpoint["ts"], | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| def search_where(metadata_query: CheckpointMetadata, predicates: List[str] = []) -> str: | |||
There was a problem hiding this comment.
Update implementation so that query values are parameterized instead of hardcoded into query.
…o that parameter values are not hardcoded, but bound instead.
Summary
This PR is a reimplementation of the old "Add FewShotExamples managed value" PR. A new PR is created because there are merge conflicts with the old PR. The changes in this PR are mostly derived from the old PR with a few noted exceptions.
Implementation
scorefield toCheckpointMetadata. Clients can specify a score for a checkpoint to mark a thread as "good". This is different from the old PR.search()andasearch()APIs toBaseCheckpointSaverfor searching checkpoints by metadata without filtering onthread_id. Implement the APIs inMemorySaver,SqliteSaver, andAsyncSqliteSaver. The implementation is mostly copied from thelist()method. The old PR implemented an API calledlist_w_score().FewShotExamplesclass from the old PR.learning.ipynbfrom the old PR.To Do
learning.ipynbnotebook.