Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output schemas to the playgrounds #522

Merged
merged 2 commits into from Mar 11, 2024
Merged

Conversation

eyurtsev
Copy link
Collaborator

@eyurtsev eyurtsev commented Mar 11, 2024

Add output schema information to the playgrounds

image

@eyurtsev
Copy link
Collaborator Author

@jacoblee93 adding output schema as constants available for the JS code. If I understand correctly, this might help the UI produce a good error toast message for non supported schema formats for inputs/outputs

@jacoblee93
Copy link
Collaborator

I think it makes more sense to throw on the backend when you set the playground_type instead of showing something on the frontend.

@jacoblee93
Copy link
Collaborator

Discussed offline

@jacoblee93 jacoblee93 merged commit e83dc5a into main Mar 11, 2024
11 checks passed
@jacoblee93 jacoblee93 deleted the eugene/add_output_schemas branch March 11, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants