[minor][doc] Updates setup instruction for LangServe app #549
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the username @rahilvora on file. In order for us to review and merge your code, please complete the Individual Contributor License Agreement here https://forms.gle/AQFbtkWRoHXUgipM6 . This process is done manually on our side, so after signing the form one of the maintainers will add you to the contributors list. For more details about why we have a CLA and other contribution guidelines please see: https://github.com/langchain-ai/langserve/blob/main/CONTRIBUTING.md. |
|
Thank you! Will review in a bit |
README.md
Outdated
| ``` | ||
|
|
||
| ### 2. Activate `poetry` shell. Every command after step 2 should be executed within `poetry` shell. | ||
| ```sh | ||
| poetry shell |
There was a problem hiding this comment.
Let's not recommend poetry shell here. Instead have folks run
poetry run [command] (e.g,. poetry run pytest)
README.md
Outdated
| poetry install | ||
| ``` | ||
|
|
||
| ### 4. Install `langchain-openai` dependency to use ChatOpenAI llm. Do similar for other dependencies you plan to use. |
There was a problem hiding this comment.
The first thing to do is to define the runnable in add_routes
so they need to go to server.py and edit add_routes(app. NotImplemented)
After that we can specify that they should add any 3rd party packages and set up env variables appropriately.
README.md
Outdated
|
|
||
| ### 4. Install `langchain-openai` dependency to use ChatOpenAI llm. Do similar for other dependencies you plan to use. | ||
| ```sh | ||
| pip intall langchain-openai |
There was a problem hiding this comment.
This should be poetry add langchain-openai, but we also need to be a bit more vendor agnostic (even though openai is super popular!)
Could we re-write to say something along the lines of:
Set up any relevant 3rd party packages (e.g., langchain-openai, langchain-anthropic, langchain-mistral etc), and set up relevant env variables
|
@rahilvora sorry for taking so long -- had a large review queue in primary langchain repo right now |
rahilvora
force-pushed
the
rahilvora/update_README
branch
from
02841cd
to
a78f15e
Compare
README.md
Outdated
| ### 3. Use `poetry` to add 3rd party packages (e.g., langchain-openai, langchain-anthropic, langchain-mistral etc) and to run any commands like tests. More details on `poetry` commands is [here](https://python-poetry.org/docs/cli/). | ||
| ```sh | ||
| poetry add [package-name] // e.g `poetry add langchain-openai` | ||
| poetry run [command] // e.g `poetry run pytest` |
There was a problem hiding this comment.
That's not an installation step
| poetry run [command] // e.g `poetry run pytest` |
There was a problem hiding this comment.
Yes the instruction for step 3 is to add 3rd party packages and run any commands
README.md
Outdated
|
|
||
| ### 5. Serve your app | ||
| ```sh | ||
| langchain serve --port=8100 |
There was a problem hiding this comment.
Do we need to do poetry run langchain serve --port=8100?
Add
Setupinstruction to runlangserveapp locally.