Add get_test_results #301
Merged
Add get_test_results #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
approved these changes
Nov 20, 2023
python/langsmith/client.py
Outdated
| execution_time = ( | ||
| (r.end_time - r.start_time).total_seconds() if r.end_time else None | ||
| ) | ||
| row["execution_time"] = execution_time |
There was a problem hiding this comment.
nit: i prefer using .update in places like that so all the updates can be done in one statement
| import pandas as pd # type: ignore | ||
|
|
||
| runs = self.list_runs( | ||
| project_id=project_id, project_name=project_name, execution_order=1 |
python/langsmith/client.py
Outdated
| @@ -1165,6 +1165,50 @@ def read_project( | |||
| **response.json(), _host_url=self._host_url | |||
| ) | |||
|
|
|||
| def get_test_results( | |||
| self, | |||
| project_id: Optional[ID_TYPE] = None, | |||
There was a problem hiding this comment.
Suggested change
| project_id: Optional[ID_TYPE] = None, | |
| *, | |
| project_id: Optional[ID_TYPE] = None, |
There was a problem hiding this comment.
not sure if you like, but i like forcing named invocation for whatever could be a literal since it makes user code more readable (but longer to type), but I like typing more code
There was a problem hiding this comment.
It's more consistent with the rest of the API so ya good point. I've grown tired of typing "project_id" so often
There was a problem hiding this comment.
but it's an opportunity to not think about anything since and let muscle memory engage for a few seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.