Async Eval Functions #605
Merged
Async Eval Functions #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client Side:
```
async def the_parent_function():
async with AsyncClient(app=fake_app, base_url="http://localhost:8000") as client:
headers = {}
if span := get_current_span():
headers.update(span.to_headers())
return await client.post("/fake-route", headers=headers)
```
Server Side:
```
@fake_app.post("/fake-route")
async def fake_route(request: Request):
with tracing_context(headers=request.headers):
fake_function()
return {"message": "Fake route response"}
```
If people like, we could add some fun middleware, but probably not
necessary
agola11
reviewed
Apr 15, 2024
Comment on lines
+201
to
+210
| >>> results = asyncio.run( | ||
| ... aevaluate( | ||
| ... apredict, | ||
| ... data=dataset_name, | ||
| ... evaluators=[helpfulness], | ||
| ... summary_evaluators=[precision], | ||
| ... experiment_prefix="My Helpful Experiment", | ||
| ... ) | ||
| ... ) # doctest: +ELLIPSIS | ||
| View the evaluation results for experiment:... |
There was a problem hiding this comment.
nit: use await instead of asyncio.run
There was a problem hiding this comment.
That breaks doctests since this is in the python repl
| RunEvaluator, | ||
| ] | ||
| ], | ||
| evaluators: Sequence[Union[EVALUATOR_T, AEVALUATOR_T]], |
There was a problem hiding this comment.
That's contained withinEVALUATOR_T
| @@ -101,6 +102,9 @@ async def aevaluate_run( | |||
| ) | |||
|
|
|||
|
|
|||
| _RUNNABLE_OUTPUT = Union[EvaluationResult, EvaluationResults, dict] | |||
|
|
|||
|
|
|||
| class DynamicRunEvaluator(RunEvaluator): | |||
There was a problem hiding this comment.
not related to PR but docstring suggests we need to use @run_evaluator decorator but don't think that's true anymore?
There was a problem hiding this comment.
You could initialize it directly or via the run_evaluator docstring.
We wrap user functions using this within the evaluate() function to promote them to RunEvaluator's
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.