Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Example Serialization #612

Merged
merged 10 commits into from
Apr 19, 2024
Merged

Fix Example Serialization #612

merged 10 commits into from
Apr 19, 2024

Conversation

hinthornw
Copy link
Collaborator

@hinthornw hinthornw commented Apr 18, 2024

(slightly breaking for comparison flows for unit testing)

  1. Update the ID representation to mostly match the pytest format of path/to/test_file.py::test_function[arg#-arg#-arg#] instead of
  2. Fallback to repr of object fo rexample inputs/outputs

Why?

  • In unit testing, the example inputs/outputs are less important. Want to permit non-serializable objects.
  • Don't want to keep creating populating new examples with new IDs just because the non-serializable object includes its memory ID in its repr

Finally start using `create_task` and copying the context to scope any
changes to the tree.

Fixes #607
@hinthornw hinthornw merged commit aba2b9e into main Apr 19, 2024
18 checks passed
@hinthornw hinthornw deleted the wfh/fix_example_serialization branch April 19, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants