Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(js): throw when wrapping same client twice, allow passing name in argsConfigExtra #663

Merged
merged 4 commits into from
May 7, 2024
Merged

fix(js): throw when wrapping same client twice, allow passing name in argsConfigExtra #663

merged 4 commits into from
May 7, 2024

Conversation

dqbd
Copy link
Collaborator

@dqbd dqbd commented May 7, 2024

  • Make sure we're only allowing wrapping once
  • Allow passing name to runnable config like

hinthornw
hinthornw reviewed May 7, 2024
View reviewed changes
js/src/run_trees.ts Outdated Show resolved Hide resolved
@dqbd dqbd requested a review from hinthornw May 7, 2024 22:02
@dqbd dqbd merged commit ceee00f into main May 7, 2024
13 checks passed
@dqbd dqbd deleted the dqbd/traceable-argsConfig-name branch May 7, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hinthornw hinthornw hinthornw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dqbd @hinthornw