Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Custom properties in Spring Boot starter are missing metadata #250

Closed
ThomasVitale opened this issue Oct 26, 2023 · 0 comments · Fixed by #251
Closed

[BUG] Custom properties in Spring Boot starter are missing metadata #250

ThomasVitale opened this issue Oct 26, 2023 · 0 comments · Fixed by #251
Labels
bug Something isn't working

Comments

@ThomasVitale
Copy link
Contributor

Describe the bug
The custom properties defined in the Spring Boot starter are missing metadata, which means IDEs will not be able to validate the properties nor help developers with autocomplete.

To Reproduce

  • Create a new Spring Boot project and add the LangChain4J starter
  • Configure a model via configuration properties in an application.yml or application.properties file
  • The IDE (e.g. Visual Studio Code or IntelliJ IDEA) will highlight the LangChain4J properties as invalid

Expected behavior
Custom properties come with metadata that IDEs can use to validate properties, provide autocomplete, and show contextual information.

Please complete the following information:

  • LangChain4j version: e.g. 0.23.0
  • Java version: e.g. 21
  • Spring Boot version (if applicable): e.g. 3.1.5

Additional context
The issue can be fixed by including the Spring Boot Configuration Processor in the starter module.
@ThomasVitale ThomasVitale added the bug Something isn't working label Oct 26, 2023
@ThomasVitale ThomasVitale mentioned this issue Oct 26, 2023
Merged
langchain4j pushed a commit that referenced this issue Oct 27, 2023
@ThomasVitale
Include metadata for custom Spring Boot properties (#251)
65ef655 
Add the Spring Boot Configuration Processor dependency to the Spring
Boot starter to generate metadata
about the LangChain4J custom properties.

Fixes gh-250
bvanloocke pushed a commit to bvanloocke/langchain4j that referenced this issue Oct 28, 2023
@ThomasVitale
Include metadata for custom Spring Boot properties (langchain4j#251)
a701a50 
Add the Spring Boot Configuration Processor dependency to the Spring
Boot starter to generate metadata
about the LangChain4J custom properties.

Fixes langchain4jgh-250
bvanloocke pushed a commit to bvanloocke/langchain4j that referenced this issue Nov 15, 2023
@ThomasVitale
Include metadata for custom Spring Boot properties (langchain4j#251)
d57ba02 
Add the Spring Boot Configuration Processor dependency to the Spring
Boot starter to generate metadata
about the LangChain4J custom properties.

Fixes langchain4jgh-250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Include metadata for custom Spring Boot properties
2 participants
@ThomasVitale @langchain4j