Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in the tutorial docs #880

Closed
GuyKe opened this issue Apr 3, 2024 · 2 comments
Closed

Broken link in the tutorial docs #880

GuyKe opened this issue Apr 3, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@GuyKe
Copy link

GuyKe commented Apr 3, 2024

In the tutorial, under RAG there are examples - (https://docs.langchain4j.dev/tutorials/rag#examples),
the "Rag + Tools" is broken and bring me to a 404. I assume this is correct link? https://github.com/langchain4j/langchain4j-examples/tree/main/customer-support-agent-example
@GuyKe GuyKe added the bug Something isn't working label Apr 3, 2024
@remyohajinwa
Copy link
Contributor

I am taking a look at this

remyohajinwa pushed a commit to remyohajinwa/langchain4j that referenced this issue Apr 4, 2024
langchain4j#880 Fix RAG + TOOLS broken link
9c2e10d
langchain4j pushed a commit that referenced this issue Apr 8, 2024
@remyohajinwa
#880 Fix RAG + TOOLS broken link (#889)
9f6fc54 
<!-- Thank you so much for your contribution! -->
<!-- Please fill in all the sections below. -->
<!-- Please note that PRs without tests will be rejected. -->

## Context
<!-- Please provide some context so that it is clear why this change is
required. -->

## Change
<!-- Please describe the changed you made. -->

## Checklist
Before submitting this PR, please check the following points:
- [ ] I have added unit and integration tests for my change
- [ ] All unit and integration tests in the module I have added/changed
are green
- [ ] All unit and integration tests in the
[core](https://github.com/langchain4j/langchain4j/tree/main/langchain4j-core)
and
[main](https://github.com/langchain4j/langchain4j/tree/main/langchain4j)
modules are green
- [ ] I have added/updated the
[documentation](https://github.com/langchain4j/langchain4j/tree/main/docs/docs)
- [ ] I have added an example in the [examples
repo](https://github.com/langchain4j/langchain4j-examples) (only for
"big" features)
- [ ] I have added my new module in the
[BOM](https://github.com/langchain4j/langchain4j/blob/main/langchain4j-bom/pom.xml)
(only when a new module is added)

## Checklist for adding new embedding store integration
- [ ] I have added a {NameOfIntegration}EmbeddingStoreIT that extends
from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT

Co-authored-by: Remy Ohajinwa <remyohajinwa@Remys-MacBook-Pro.local>
@langchain4j
Copy link
Owner

Fixed in #889

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GuyKe @remyohajinwa @langchain4j