Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Judge0 code execution engine as module #1051

Merged
merged 12 commits into from
May 21, 2024

Conversation

anunnakian
Copy link
Contributor

@anunnakian anunnakian commented May 2, 2024

Please see the issue #1048

Change

I extract these classes as new module langchain4j-code-execution-engine-judge0 :

  • Judge0JavaScriptEngine
  • JavaScriptCodeFixer
  • Judge0JavaScriptExecutionTool
  • JavaScriptCodeFixerTest

and I moved the com.squareup.okhttp3:okhttp dependency from the main module to that new one.

General checklist

  • There are no breaking changes
  • I have added unit and integration tests for my change
  • I have manually run all the unit and integration tests in the module I have added/changed, and they are all green
  • I have manually run all the unit and integration tests in the core and main modules, and they are all green

Checklist for adding new model integration

  • I have added my new module in the BOM

Checklist for adding new embedding store integration

  • I have added a {NameOfIntegration}EmbeddingStoreIT that extends from either EmbeddingStoreIT or EmbeddingStoreWithFilteringIT
  • I have added my new module in the BOM

Checklist for changing existing embedding store integration

  • I have manually verified that the {NameOfIntegration}EmbeddingStore works correctly with the data persisted using the latest released version of LangChain4j

@langchain4j langchain4j added the P2 High priority label May 2, 2024
@anunnakian anunnakian marked this pull request as draft May 15, 2024 20:48
Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anunnakian thanks a lot!

langchain4j/pom.xml Outdated Show resolved Hide resolved
@langchain4j langchain4j marked this pull request as ready for review May 21, 2024 06:46
@langchain4j
Copy link
Owner

@anunnakian thank you a lot!

@langchain4j langchain4j merged commit b27fd4d into langchain4j:main May 21, 2024
6 checks passed
@anunnakian anunnakian deleted the extract_engine_judge0_module branch May 21, 2024 06:55
@konczdev
Copy link

konczdev commented May 21, 2024

@langchain4j I think it is late but the base package should be dev.langchain4j.code.judge or dev.langchain4j.code.judge0 instead of dev.langchain4j.code.

The langchain4j-code-execution-engine-graalvm-polyglot did this correctly with dev.langchain4j.code.graalvm.

Keeping dev.langchain4j.code introduces a new split package problem with langchain4j-core. #1066

Edit: maybe the checklist should include the base package uniqeness for each module

@anunnakian
Copy link
Contributor Author

Yes you're right, my bad!
I'll fix this

@anunnakian
Copy link
Contributor Author

Here is the fix @konczdev : #1136
@langchain4j what do you think ?

@konczdev
Copy link

@anunnakian looks good.

There are 2 references in the the example repo too:
tutorials/src/main/java/_11_ServiceWithDynamicToolsExample.java
other-examples/src/main/java/ServiceWithDynamicToolsExample.java

@anunnakian
Copy link
Contributor Author

I'll update that after the merge, Thank you @konczdev

@langchain4j
Copy link
Owner

@konczdev thanks a lot for spotting it and @anunnakian for fixing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants