-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract Judge0 code execution engine as module #1051
Extract Judge0 code execution engine as module #1051
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anunnakian thanks a lot!
@anunnakian thank you a lot! |
@langchain4j I think it is late but the base package should be The langchain4j-code-execution-engine-graalvm-polyglot did this correctly with Keeping Edit: maybe the checklist should include the base package uniqeness for each module |
Yes you're right, my bad! |
Here is the fix @konczdev : #1136 |
@anunnakian looks good. There are 2 references in the the example repo too: |
I'll update that after the merge, Thank you @konczdev |
@konczdev thanks a lot for spotting it and @anunnakian for fixing! |
Please see the issue #1048
Change
I extract these classes as new module
langchain4j-code-execution-engine-judge0
:Judge0JavaScriptEngine
JavaScriptCodeFixer
Judge0JavaScriptExecutionTool
JavaScriptCodeFixerTest
and I moved the
com.squareup.okhttp3:okhttp
dependency from the main module to that new one.General checklist
Checklist for adding new model integration
Checklist for adding new embedding store integration
{NameOfIntegration}EmbeddingStoreIT
that extends from eitherEmbeddingStoreIT
orEmbeddingStoreWithFilteringIT
Checklist for changing existing embedding store integration
{NameOfIntegration}EmbeddingStore
works correctly with the data persisted using the latest released version of LangChain4j