Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Adds SearchApi as WebSearchEngine and Tool #1216
base: main
Are you sure you want to change the base?
[FEATURE] Adds SearchApi as WebSearchEngine and Tool #1216
Changes from all commits
1080630
fe50b83
79e6e81
7a5656f
6f1c1f2
6ebfe8b
9a8aba9
e364031
e7004d6
fe4c080
1a6fdce
3b6e010
8b3408e
7c8e271
981e1e2
c97c0fd
f949d6c
caef543
647b992
6807aa1
6d168a6
7496cd8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We've started a few months ago to move JSON lib in LLM integration to Jackson to be compatible with java frameworks (spring, quarkus, etc). Any web search integration would be used with a LLM integration together in a normal way. It's not critical but as new integration would be great if you use Jackson mapper.
Check Anthropic or Mistral AI integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, Jackson mapper instead of
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally your Builder class should validate If
baseUrl
is mandatory for the API. If you're using lombok could add them in your main constructor:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here,
JacksonConverterFactory
instead ofThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the name of that class is weird, here you still don't use webSearch as such. A better name might be
SearchApi
for the interface andSearchApiClient
for the client.