feat: add OllamaChatModel and its corresponding integration test #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new implementation of ChatLanguageModel, OllamaChatModel, is added to handle interactions with the Ollama AI and has an associated integration test. This includes necessary configurations and methods for message generation. This increases the project's modularity and provides a more convenient and encapsulated way of interfacing with the Ollama AI.
langchain4j
requested changes
Dec 5, 2023
langchain4j-ollama/src/main/java/dev/langchain4j/model/ollama/OllamaChatModel.java
Outdated
Show resolved
Hide resolved
langchain4j-ollama/src/main/java/dev/langchain4j/model/ollama/OllamaChatModel.java
Outdated
Show resolved
Hide resolved
langchain4j-ollama/src/test/java/dev/langchain4j/model/ollama/OllamaChatModelIT.java
Outdated
Show resolved
Hide resolved
langchain4j-ollama/src/test/java/dev/langchain4j/model/ollama/OllamaChatModelIT.java
Outdated
Show resolved
Hide resolved
langchain4j-ollama/src/test/java/dev/langchain4j/model/ollama/OllamaChatModelIT.java
Show resolved
Hide resolved
Added a validation to ensure that modelName in OllamaLanguageModel, OllamaChatModel, and OllamaEmbeddingModel classes is not blank. This change will prevent situations where a model is created with an empty or null modelName, which would likely cause errors during execution. Validation is done using the ensureNotBlank utility method from ValidationUtils.
…hich can be used to guide the AI's responses.
langchain4j
reviewed
Dec 14, 2023
langchain4j-ollama/src/test/java/dev/langchain4j/model/ollama/OllamaChatModelIT.java
Outdated
Show resolved
Hide resolved
…ge class represents a chat message. The ChatRequest class represents a request to the Ollama. The ChatResponse class represents a response from the Ollama. The Role enum represents the role of a chat message sender. It also provides a method to convert from ChatMessageType to Role.
langchain4j
requested changes
Dec 15, 2023
There was a problem hiding this comment.
@fintanmm great job, thank you! There are just a few things that should be addressed and we can merge.
langchain4j-ollama/src/main/java/dev/langchain4j/model/ollama/ChatRequest.java
Outdated
Show resolved
Hide resolved
langchain4j-ollama/src/main/java/dev/langchain4j/model/ollama/OllamaChatModel.java
Outdated
Show resolved
Hide resolved
langchain4j-ollama/src/main/java/dev/langchain4j/model/ollama/OllamaChatModel.java
Outdated
Show resolved
Hide resolved
langchain4j-ollama/src/main/java/dev/langchain4j/model/ollama/OllamaClient.java
Outdated
Show resolved
Hide resolved
langchain4j-ollama/src/test/java/dev/langchain4j/model/ollama/AbstractOllamaInfrastructure.java
Outdated
Show resolved
Hide resolved
langchain4j-ollama/src/main/java/dev/langchain4j/model/ollama/OllamaApi.java
Outdated
Show resolved
Hide resolved
…se. Rename completion to chat. The renaming provides a more descriptive and intuitive name.
langchain4j
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new implementation of ChatLanguageModel, OllamaChatModel, is added to handle interactions with the Ollama AI and has an associated integration test. This includes necessary configurations and methods for message generation. This increases the project's modularity and provides a more convenient and encapsulated way of interfacing with the Ollama AI.