Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the thread safety issue in InMemoryEmbeddingStore. #351

Merged
merged 2 commits into from
Dec 14, 2023
Merged

fix the thread safety issue in InMemoryEmbeddingStore. #351

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0cc3ca
fix the thread safety issue in InMemoryEmbeddingStore.
Dec 13, 2023
1e3da84
Merge branch 'main' into main
langchain4j Dec 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...hain4j/src/main/java/dev/langchain4j/store/embedding/inmemory/InMemoryEmbeddingStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
import java.util.List;
import java.util.Objects;
import java.util.PriorityQueue;
import java.util.concurrent.CopyOnWriteArrayList;

/**
* An {@link EmbeddingStore} that stores embeddings in memory.
Expand Down Expand Up @@ -66,7 +67,7 @@ public int hashCode() {
}
}

private final List<Entry<Embedded>> entries = new ArrayList<>();
private final List<Entry<Embedded>> entries = new CopyOnWriteArrayList<>();

@Override
public String add(Embedding embedding) {
Expand Down