Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update language models and tests for Azure OpenAI #573

Merged
merged 3 commits into from Feb 8, 2024

Conversation

jdubois
Copy link
Contributor

@jdubois jdubois commented Jan 30, 2024

This PR update the language models for Azure OpenAI, and improves some tests:

  • It updates the current models available on Azure OpenAI, removing those which are not available like gpt-4-0314, gpt-3.5-turbo-0301
  • It creates some upcoming models as described in https://openai.com/blog/new-embedding-models-and-api-updates
  • It passes those updated model names to the integration tests and fixes some issues there: I have no idea why we were testing for "length" and not for "stop", so now we do both correctly.
  • Also the Dall E 3 test was "disabled", so I enabled it again.

Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdubois awesome, thank you!

public static final String GPT_3_5_TURBO_0613 = "gpt-3.5-turbo-0613"; // 4k context, functions
public static final String GPT_3_5_TURBO_0125 = "gpt-3.5-turbo-0125"; // 4k context, functions
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to split this class into multiple enums: one per model type, like OpenAiChatModelName, OpenAiEmbeddingModelName, etc. These enums can be then accepted by model builder for convenience (in addition to strings).

@langchain4j langchain4j merged commit 3236162 into langchain4j:main Feb 8, 2024
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants