New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update usage of PostgreSQLContainer with pgvector/pgvector image #703
Conversation
Testcontainers PostgreSQL module accepts `pgvector/pgvector` as a valid image since version 1.19.7.
Important Auto Review SkippedReview was skipped due to path filters Files ignored due to path filters (2)
WalkthroughThe update focuses on changing the PostgreSQL container image used in the test setup for Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (3)
langchain4j-parent/pom.xml
is excluded by:!**/*.xml
langchain4j-pgvector/pom.xml
is excluded by:!**/*.xml
langchain4j-pgvector/src/test/resources/logback-test.xml
is excluded by:!**/*.xml
Files selected for processing (2)
- langchain4j-pgvector/src/test/java/dev/langchain4j/store/embedding/pgvector/PgVectorEmbeddingIndexedStoreIT.java (1 hunks)
- langchain4j-pgvector/src/test/java/dev/langchain4j/store/embedding/pgvector/PgVectorEmbeddingStoreIT.java (1 hunks)
Additional comments: 2
langchain4j-pgvector/src/test/java/dev/langchain4j/store/embedding/pgvector/PgVectorEmbeddingStoreIT.java (1)
- 17-17: The update to the PostgreSQL container image reference from
"ankane/pgvector:v0.5.1"
to"pgvector/pgvector:pg15"
is correctly implemented. This change aligns with the PR objectives to leverage the latestpgvector
capabilities and the support introduced inTestcontainers
version 1.19.7 for this specific image. Ensure that this version of thepgvector
Docker image is compatible with the rest of your test setup and PostgreSQL version requirements.langchain4j-pgvector/src/test/java/dev/langchain4j/store/embedding/pgvector/PgVectorEmbeddingIndexedStoreIT.java (1)
- 17-17: The update to the PostgreSQL container image reference in
PgVectorEmbeddingIndexedStoreIT
to"pgvector/pgvector:pg15"
is correctly implemented, mirroring the change made inPgVectorEmbeddingStoreIT
. This consistency across test classes ensures that all integration tests forpgvector
functionality are using the same, updated Docker image. As with the previous file, verify that this Docker image version is fully compatible with your testing requirements and PostgreSQL version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eddumelendez thank you!
Testcontainers PostgreSQL module accepts
pgvector/pgvector
as a valid image since version 1.19.7.
Summary by CodeRabbit