Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update usage of PostgreSQLContainer with pgvector/pgvector image #703

Merged
merged 3 commits into from Mar 19, 2024

Conversation

eddumelendez
Copy link
Contributor

@eddumelendez eddumelendez commented Mar 5, 2024

Testcontainers PostgreSQL module accepts pgvector/pgvector
as a valid image since version 1.19.7.

Summary by CodeRabbit

  • Tests
    • Updated the PostgreSQL container image used in tests for enhanced compatibility and performance.

Testcontainers PostgreSQL module accepts `pgvector/pgvector`
as a valid image since version 1.19.7.
Copy link

coderabbitai bot commented Mar 7, 2024

Important

Auto Review Skipped

Review was skipped due to path filters

Files ignored due to path filters (2)
  • langchain4j-parent/pom.xml is excluded by: !**/*.xml
  • langchain4j-pgvector/pom.xml is excluded by: !**/*.xml

Walkthrough

The update focuses on changing the PostgreSQL container image used in the test setup for PgVectorEmbeddingIndexedStoreIT and PgVectorEmbeddingStoreIT classes. This adjustment from "ankane/pgvector:v0.5.1" to "pgvector/pgvector:pg15" likely signifies a move to a newer version or a switch in the source of the image, ensuring compatibility or leveraging improvements in PostgreSQL vector handling.

Changes

Files Change Summary
.../pgvector/PgVectorEmbeddingIndexedStoreIT.java, PgVectorEmbeddingStoreIT.java Updated PostgreSQL container image from "ankane/pgvector:v0.5.1" to "pgvector/pgvector:pg15"

🐰✨

In the realm of code, where vectors align,
A rabbit hopped through, making changes so fine.
From ankane to pgvector, a leap so bold,
Through PostgreSQL versions, new stories told.
Let's celebrate the update, with joy and cheer,
For progress and improvements, are always near.

🚀🌟

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 657aac9 and 27a2bf7.
Files ignored due to path filters (3)
  • langchain4j-parent/pom.xml is excluded by: !**/*.xml
  • langchain4j-pgvector/pom.xml is excluded by: !**/*.xml
  • langchain4j-pgvector/src/test/resources/logback-test.xml is excluded by: !**/*.xml
Files selected for processing (2)
  • langchain4j-pgvector/src/test/java/dev/langchain4j/store/embedding/pgvector/PgVectorEmbeddingIndexedStoreIT.java (1 hunks)
  • langchain4j-pgvector/src/test/java/dev/langchain4j/store/embedding/pgvector/PgVectorEmbeddingStoreIT.java (1 hunks)
Additional comments: 2
langchain4j-pgvector/src/test/java/dev/langchain4j/store/embedding/pgvector/PgVectorEmbeddingStoreIT.java (1)
  • 17-17: The update to the PostgreSQL container image reference from "ankane/pgvector:v0.5.1" to "pgvector/pgvector:pg15" is correctly implemented. This change aligns with the PR objectives to leverage the latest pgvector capabilities and the support introduced in Testcontainers version 1.19.7 for this specific image. Ensure that this version of the pgvector Docker image is compatible with the rest of your test setup and PostgreSQL version requirements.
langchain4j-pgvector/src/test/java/dev/langchain4j/store/embedding/pgvector/PgVectorEmbeddingIndexedStoreIT.java (1)
  • 17-17: The update to the PostgreSQL container image reference in PgVectorEmbeddingIndexedStoreIT to "pgvector/pgvector:pg15" is correctly implemented, mirroring the change made in PgVectorEmbeddingStoreIT. This consistency across test classes ensures that all integration tests for pgvector functionality are using the same, updated Docker image. As with the previous file, verify that this Docker image version is fully compatible with your testing requirements and PostgreSQL version.

Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddumelendez thank you!

@langchain4j langchain4j merged commit 370fd0c into langchain4j:main Mar 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants