Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Mistral AI supports function calling #767

Merged
merged 50 commits into from Mar 25, 2024

Conversation

czelabueno
Copy link
Contributor

This PR adds function calling support for MistralAI chat and streaming completions models.

Also, add and deprecate the Mistral AI models like:

  • open-mistral-7b, 
  • open-mixtral-8x7b, 
  • mistral-small-latest, 
  • mistral-medium-latest, 
  • mistral-large-latest,
  • mistral-tiny (deprecated)
  • mistral-medium (deprecated)

Others PR related:

  1. MistralAI Examples with function calling PR#68
  2. MistralAI Function Calling documentation PR#765
  3. Updating the integration table by adding the function calling as new column for other integrations PR#766

czelabueno and others added 30 commits January 15, 2024 17:25
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Merge upstream/main March8 2024
Copy link

coderabbitai bot commented Mar 16, 2024

Warning

Rate Limit Exceeded

@czelabueno has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 30 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between 91db3d3 and 056a172.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

LizeRaes and others added 2 commits March 16, 2024 15:02
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
langchain4j
langchain4j previously approved these changes Mar 19, 2024
Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czelabueno thank you a lot, great job as always! I have left a few minor comments/suggestions, but we could also merge it. LMK if you want to address these comments before the next release (this friday or next monday)

Co-authored-by: LangChain4j <langchain4j@gmail.com>
czelabueno and others added 9 commits March 24, 2024 14:09
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Co-authored-by: LangChain4j <langchain4j@gmail.com>
Co-authored-by: LangChain4j <langchain4j@gmail.com>
@czelabueno
Copy link
Contributor Author

czelabueno commented Mar 25, 2024

@langchain4j this PR has been updated with the resolution of all your comments.
About AiServicesWithToolsIT, the chatLanguageModelProvider() method has been generated, which is being used to parameterize the test by @MethodSource.
So far it has implemented OpenAI and MistralAI models. I have only updated the tests that make sense for both of us.

Additionally, I updated TestStreamingResponseHandler to support AiMessage.text() as null so that some streaming tests that use this class and support function calls don't break.

Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czelabueno thank you so much, great job! And right in time for the release :)

@langchain4j langchain4j merged commit ae68bf9 into langchain4j:main Mar 25, 2024
6 checks passed
@czelabueno czelabueno deleted the mistralai-function-calling branch March 25, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants