Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #833: DocumentByParagraphSplitter regex JDK version adaptation #843

Merged
merged 1 commit into from Mar 28, 2024
Merged

Fix #833: DocumentByParagraphSplitter regex JDK version adaptation #843

merged 1 commit into from Mar 28, 2024

Conversation

Kugaaa
Copy link
Contributor

@Kugaaa Kugaaa commented Mar 27, 2024 •
edited

Context

See #833

Change

DocumentByParagraphSplitter split regular expression

Checklist

Before submitting this PR, please check the following points:

  • I have added unit and integration tests for my change
  • All unit and integration tests in the module I have added/changed are green
  • All unit and integration tests in the core and main modules are green
  • I have added/updated the documentation
  • I have added an example in the examples repo (only for "big" features)
  • I have added my new module in the BOM (only when a new module is added)

langchain4j
langchain4j approved these changes Mar 28, 2024
View reviewed changes
Copy link
Owner

@langchain4j langchain4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kugaaa thanks a lot!

@langchain4j langchain4j merged commit b07964e into langchain4j:main Mar 28, 2024
1 check passed
langchain4j added a commit that referenced this pull request Mar 28, 2024
@langchain4j
Fix #833: DocumentByParagraphSplitter regex JDK version adaptation (#843
1dc55a9 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langchain4j langchain4j langchain4j approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kugaaa @langchain4j