Removing incorrect end comma in jsonStructure for POJO extracting AI Services #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 7, 2024 18:36
Shastick
reviewed
Apr 7, 2024
langchain4j/src/main/java/dev/langchain4j/service/ServiceOutputParser.java
Show resolved
Hide resolved
Shastick
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I noted that for more complex POJO object, the JSON returned by the LLM often contained a last comma before closing bracket, making the JSON invalid and resulting in an error while parsing it. I traced it back to the proposed jsonStructure that is part of the SystemMessage, sending a wrong format to the LLM.
Change
Removed the last comma that shouldn't be there in the jsonStructure + updated the unit tests