Fix #913: FileSystemDocumentLoader: ignore empty/blank documents, improved error/warn messages #920
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
When loading with
FileSystemDocumentLoader
and it encounters an empty file, a WARN message in the logs looks like an exception and is confusing.See #913
Change
DocumentIsBlankException
Checklist
Before submitting this PR, please check the following points:
Checklist for adding new embedding store integration