New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge OpenAiStreamingChatModel and OpenAiChatModel classes #971
Draft
anunnakian
wants to merge
26
commits into
langchain4j:main
Choose a base branch
from
anunnakian:remove_OpenAiStreamingChatModel
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Merge OpenAiStreamingChatModel and OpenAiChatModel classes #971
anunnakian
wants to merge
26
commits into
langchain4j:main
from
anunnakian:remove_OpenAiStreamingChatModel
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anunnakian
force-pushed
the
remove_OpenAiStreamingChatModel
branch
from
April 20, 2024 21:57
12d7e82
to
b7c85e3
Compare
… into remove_OpenAiStreamingChatModel # Conflicts: # langchain4j-open-ai/src/main/java/dev/langchain4j/model/openai/OpenAiChatModel.java
… into remove_OpenAiStreamingChatModel
Hello @LizeRaes, here is my PR that I made during the Devoxx session, please take a look when you have time 🤓 |
langchain4j
requested changes
Apr 26, 2024
langchain4j-open-ai/src/main/java/dev/langchain4j/model/openai/OpenAiStreamingChatModel.java
Outdated
Show resolved
Hide resolved
anunnakian
changed the title
Avoid using OpenAiStreamingChatModel class
Merge OpenAiStreamingChatModel and OpenAiChatModel classes
Apr 27, 2024
Thanks a lot @anunnakian , nice for streamlining experience! Looking forward to the minor fixes and getting it merged :) |
anunnakian
force-pushed
the
remove_OpenAiStreamingChatModel
branch
2 times, most recently
from
May 1, 2024 10:47
37ad3d5
to
32748b9
Compare
anunnakian
force-pushed
the
remove_OpenAiStreamingChatModel
branch
from
May 1, 2024 10:48
32748b9
to
0a0ac22
Compare
Minor changes done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fix the issue #954
Change
Checklist
Before submitting this PR, please check the following points:
Checklist for adding new embedding store integration