Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove "Centiment" option in demographics #482

Closed
vmarchman opened this issue Nov 7, 2023 · 10 comments
Closed

remove "Centiment" option in demographics #482

vmarchman opened this issue Nov 7, 2023 · 10 comments
Assignees
Projects

Comments

@vmarchman
Copy link
Contributor

vmarchman commented Nov 7, 2023

@HenryMehta Currently, the demographic options still have the "Centiment" option that we used for an earlier study. It's not working now so please remove this option from the demographics dropdown.

HenryMehta added a commit that referenced this issue Nov 8, 2023
@HenryMehta
Copy link
Collaborator

@vmarchman deployed to Dev

@HenryMehta HenryMehta self-assigned this Nov 8, 2023
@HenryMehta HenryMehta added this to To do in Fixes via automation Nov 9, 2023
@HenryMehta HenryMehta moved this from To do to Review in progress in Fixes Nov 9, 2023
@HenryMehta
Copy link
Collaborator

@vmarchman I don't see where you are still seeing Centiment option. I have removed it from the dropdown when creating/editing a study and cannot find it elsewhere

@HenryMehta
Copy link
Collaborator

@vmarchman found it - try now

@vmarchman
Copy link
Contributor Author

@HenryMehta. Agree the option is gone from the Create study dialog. And, only the demographic options for that form are listed.

But in the UPDATE study dialog, you see all of the demographic options, including centiment and those that don't belong to that language form. that is, you see French_split.json, for example, when updating a study with English WG

@HenryMehta
Copy link
Collaborator

@vmarchman please check the Update dialog again. It does limit the demographic options but it has to load the page first and then do the limiting to those available so takes a few seconds (depending on how good your internet speed is)

@vmarchman
Copy link
Contributor Author

vmarchman commented Nov 10, 2023 via email

@HenryMehta
Copy link
Collaborator

@vmarchman Don't refresh the page. Give it 10 seconds or so and then check the options

@vmarchman
Copy link
Contributor Author

vmarchman commented Nov 10, 2023 via email

@HenryMehta
Copy link
Collaborator

ok - strange since works for me. I'll take a look tomorrow

@HenryMehta
Copy link
Collaborator

@vmarchman Found the issue. It was limiting the demographic options if anything other than the default had been selected. But if the default was being used it wasn't limiting the options. Deploying fix to dev now

HenryMehta added a commit that referenced this issue Nov 14, 2023
* #482 Remove Centiment option

* #481 Amendment to WG clinical report

* #475 handle adjusted age on clinical reports

* #475 handle adjusted age on clinical reports

* #475 handle adjusted age on clinical reports

* #482 Remove Centiment dempgraphic option

* #482 ensure demographic options update/are limited to those for instrument

* #482 ensure demographic options update/are limited to those for instrument

* #483 Correction for completed_date

* #483 add crontab job to run completed_date correction
@HenryMehta HenryMehta moved this from Review in progress to Reviewer approved in Fixes Nov 14, 2023
Fixes automation moved this from Reviewer approved to Done Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Fixes
Done
Development

No branches or pull requests

2 participants