New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in deployment procedure in AWS CDK and support HTTPS #1491
Merged
ogabrielluiz
merged 24 commits into
langflow-ai:dev
from
kazuki306:aws-cdk-s3-alb-cf-origin
Mar 4, 2024
Merged
Fix bug in deployment procedure in AWS CDK and support HTTPS #1491
ogabrielluiz
merged 24 commits into
langflow-ai:dev
from
kazuki306:aws-cdk-s3-alb-cf-origin
Mar 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XL
This PR changes 500-999 lines, ignoring generated files.
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
labels
Mar 4, 2024
ogabrielluiz
approved these changes
Mar 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. Thanks, @kazuki306 . This looks great. Can't wait to try it.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
documentation
Improvements or additions to documentation
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
size:XL
This PR changes 500-999 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1052
We have reviewed our architecture to fix some issues.
We have changed to deploy the built frontend to S3 and the backend to a container (ECS) to be distributed via CloudFront. It allows access to applications using HTTPS.
We have confirmed that it works with Langflow v0.6.9.
See
/langflow/scripts/aws/README.md
for detailed architecture and deployment instructions.