Add new tests on global variables and fix old ones #1756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…run_frontend target 📝 (frontend/.gitignore): add test-results/ directory to .gitignore ⬆️ (frontend/package.json): upgrade @playwright/test dependency to version 1.43.1 💡 (frontend/tests/end-to-end/filterEdge.spec.ts): update expected tooltip test ID from "tooltip-Models" to "tooltip-Model Specs" 💡 (frontend/tests/end-to-end/filterEdge.spec.ts): update expected test ID from "disclosure-models" to "disclosure-model specs" 💡 (frontend/tests/end-to-end/globalVariables.spec.ts): add hover and delete functionality to test for global variables 💡 (frontend/tests/end-to-end/saveComponents.spec.ts): add additional wait times to ensure modal is loaded before interacting with it
…fore starting the frontend server to avoid conflicts
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…tOutput variable to improve test readability
…ks for invalid syntax in the test case ♻️ (codeAreaModalComponent.spec.ts): refactor test case to remove redundant code and improve readability
…e unused import to improve code readability and maintainability ✅ (store.spec.ts): add a delay before selecting the "Alphabetical" option to ensure the dropdown is fully loaded before interacting with it
ogabrielluiz
approved these changes
Apr 23, 2024
If you're cool with it, let's start by testing it this way in the pipeline. Then, in a further moment, we can come back with more time to tweak things based on how the tests go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 (Makefile): remove unnecessary kill command for frontend server in run_frontend target
📝 (frontend/.gitignore): add test-results/ directory to .gitignore
⬆️ (frontend/package.json): upgrade @playwright/test dependency to version 1.43.1
💡 (frontend/tests/end-to-end/filterEdge.spec.ts): update expected tooltip test ID from "tooltip-Models" to "tooltip-Model Specs"
💡 (frontend/tests/end-to-end/filterEdge.spec.ts): update expected test ID from "disclosure-models" to "disclosure-model specs"
💡 (frontend/tests/end-to-end/globalVariables.spec.ts): add hover and delete functionality to test for global variables
💡 (frontend/tests/end-to-end/saveComponents.spec.ts): add additional wait times to ensure modal is loaded before interacting with it