Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Refactor: Add playground check before opening" #1845

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

anovazzi1
Copy link
Contributor

This pull request refactors the CollectionCardComponent to add a playground check before opening it. The hasPlayground function is introduced to determine if a flow has a playground. If a flow doesn't have a playground, an error message is displayed. This change improves the user experience by preventing the opening empty playgrounds

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label May 7, 2024
Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview May 7, 2024 2:27am

@dosubot dosubot bot added the javascript Pull requests that update Javascript code label May 7, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 7, 2024
@anovazzi1 anovazzi1 merged commit 0226706 into dev May 7, 2024
6 of 7 checks passed
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request May 15, 2024
Refactor: Add playground check before opening (langflow-ai#1844)
(cherry picked from commit 0226706)
nicoloboschi pushed a commit to datastax/ragstack-ai-langflow that referenced this pull request May 15, 2024
Refactor: Add playground check before opening (langflow-ai#1844)
(cherry picked from commit 0226706)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants