Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Updated Chat History for Astra DB #1895

Merged
merged 4 commits into from
May 23, 2024

Conversation

erichare
Copy link
Contributor

This Pull Request adds Chat History based on session IDs for Astra DB.

Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2024 2:49pm

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels May 14, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 15, 2024
@erichare
Copy link
Contributor Author

@nicoloboschi i made the changes you listed, let me know if this looks better. Thank you!

Copy link
Collaborator

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@erichare
Copy link
Contributor Author

@ogabrielluiz anything holding back the merge? I see a build issue but i think thats unrelated, correct me if im wrong?

I'd be happy to add a test or some kind of validation, just might need a little guidance there - maybe there's something for Zep available? Just let me know if so!

@ogabrielluiz
Copy link
Contributor

@erichare should be good to go. It is still a bit hard to add automated tests for these integration components.

@ogabrielluiz ogabrielluiz merged commit 0347709 into langflow-ai:dev May 23, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants