Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused local symbols #1946

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

chyok
Copy link
Contributor

@chyok chyok commented May 22, 2024

This PR removes unused local symbols, which can provide a small performance improvement by reducing unnecessary initializations.
The variables being removed have a redeclaration of the variable in each conditional branch below, so they should be safe to remove.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 22, 2024
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
langflow ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 2:56pm

@dosubot dosubot bot added the python Pull requests that update Python code label May 22, 2024
Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chyok

Thanks for the PR.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 23, 2024
@chyok
Copy link
Contributor Author

chyok commented May 23, 2024

Hi @ogabrielluiz
I have resolved the conflict.
PTAL

Copy link
Contributor

@ogabrielluiz ogabrielluiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ogabrielluiz ogabrielluiz merged commit ece3686 into langflow-ai:dev May 23, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer python Pull requests that update Python code size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants